fix(scripts): drop unused HOOK_KEY constant from install_cc_hook.py - #173
Closed
Coding-Dev-Tools wants to merge 1 commit into
Closed
fix(scripts): drop unused HOOK_KEY constant from install_cc_hook.py#173Coding-Dev-Tools wants to merge 1 commit into
Coding-Dev-Tools wants to merge 1 commit into
Conversation
The constant was declared but never referenced; the idempotency check in install()/uninstall() matches on the `command` string instead. Drop the dead identifier so a reviewer doesn't flag it. Follow-up to #171 (review pass 2).
Owner
Author
|
Superseded by 6cdfc57 (owner's review-response commit on PR1) which rewrote install_cc_hook.py and dropped HOOK_KEY as part of the idempotency refactor. The dead-constant fix is already in the main PR1 history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #171. Review pass 2 found one dead identifier in the freshly
added
scripts/install_cc_hook.py: theHOOK_KEY = "cc-engraphis-session-start"constant declared at the top of the module is never referenced anywhere.
The idempotency check in
install()/uninstall()matches on thecommandstring instead. This PR drops the dead identifier so areviewer of #171 doesn't have to flag it.
One file, one line removed, all 131 PR1 + hook installer + smart-gateway
tests still pass (
tests/test_session_start_hook.py,tests/test_smart_mcp_gateway.py,tests/test_mcp_server.py).Reviewer suggestion source: PR #171 review pass 2 (commit 725bb6e on top
of 4ec6291).