-
Notifications
You must be signed in to change notification settings - Fork 0
chore(autopilot-core): add codeowners, harden workflow permissions, extend operator timeout coverage #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autopilot-core): add codeowners, harden workflow permissions, extend operator timeout coverage #14
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| * @Coding-Autopilot-System/core | ||
| /.github/ @Coding-Autopilot-System/core |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ permissions: | |
| jobs: | ||
| installer: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On orgs where the repository loop takes over 15 minutes, especially when opted-in repos are cloned, committed, pushed, and PR-created, this new cap can cancel the shell in the middle of a repo. The workflow previously inherited GitHub's 360-minute default; after cancellation between Useful? React with 👍 / 👎. |
||
| env: | ||
| ORG: ${{ vars.ORG }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # F-07 operator timeout safety | ||
|
|
||
| Issue Description: The GitHub Actions operator job could time out after marking an issue `in-progress`, leaving it stranded until a later manual cleanup. | ||
| State: The workflow timeout was too short for the intended batch work of clone, Codex, dependency install, and tests. | ||
| Action: Increased `.github/workflows/autopilot-operator.yml` timeout to 60 minutes and added a contract assertion in `tests/contract-tests.ps1`. | ||
| Result: The operator job now has enough time for its designed batch work, and CI prevents the timeout from being reduced unnoticed. | ||
| Diff Patch: Updated the workflow timeout and added a workflow contract check. | ||
| Rationale: Batch automation should not strand claim-state on a predictable timeout boundary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the default
MAX_ISSUESof 5, this job can legitimately spend more than an hour across Codex plus dependency installs and tests. GitHub's workflow syntax docs state thattimeout-minutesauto-cancels the job and defaults to 360 minutes, so this new 60-minute cap is a sixfold reduction from the previous behavior; when it fires afterRun operatorhas removedqueuedand addedin-progress, PowerShell never reaches the catch block that marks the issue blocked, recreating the stranded in-progress state this change is meant to prevent.Useful? React with 👍 / 👎.