test(autogen): land coverage suite, dashboard style overrides, and contract fixes#10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43bbedc596
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Run full test suite | ||
| run: python -m pytest -q --tb=short | ||
| run: python -m pytest -q --tb=short --cov=. --cov-report=xml |
There was a problem hiding this comment.
Add pytest-cov before using --cov in CI
This job installs only requirements.txt, which declares pytest but not pytest-cov, and then invokes pytest with coverage flags. In a clean environment without the plugin, python -m pytest -q --tb=short --cov=. --cov-report=xml --collect-only fails with unrecognized arguments: --cov=. --cov-report=xml, so the CI job will stop before running tests on GitHub runners. Add pytest-cov to the installed dependencies or remove these flags.
Useful? React with 👍 / 👎.
| static_dir = Path(__file__).with_name("static") | ||
| if static_dir.exists(): | ||
| app.mount("/static", StaticFiles(directory=static_dir), name="static") | ||
| install_devui_ui_overrides(app) |
There was a problem hiding this comment.
Avoid injecting DevUI assets with stale file headers
When the legacy dashboard serves its existing static index, the / route returns a FileResponse, which includes the original Content-Length. Installing install_devui_ui_overrides here makes the middleware lengthen that HTML body while reusing headers=dict(response.headers), so the response can advertise the old shorter length; ASGI servers or clients that enforce Content-Length can truncate or fail the dashboard load when visiting /. Remove/recompute Content-Length in the override before applying it to this app, or avoid the override for the dashboard.
Useful? React with 👍 / 👎.
dcac47b to
1bd91da
Compare
Summary
test_autogen.py, ignores.coverage, and hardens workflow permissions/timeouts acrossci.yml,codeql.yml,pages.yml,pr-lint.yml,stale.ymlautogen_dashboard/app.py)maf_starter/loop_worker_cli.py27 files changed, +483/-25.
Part of the Phase 30 release train (
.planning/phases/30-release-train-and-branch-hygiene/).Note: This branch touches
.github/workflows/ci.yml, which also changed in dependabot PR #8. Merge #8 first, then rungh pr update-branchon this PR before merging, keeping both the bumped action versions (from #8) and the coverage/test changes (from this branch).🤖 Generated with Claude Code