Enhanced license validation - #2999
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for fa35862 is ready 🛎️!
|
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Otter Pro license activation messaging for ineligible Neve plans and preserves failure notices.
Changes:
- Adds plan-aware license error handling.
- Prevents reloads after failed license operations.
- Adds PHP tests for license scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
class-dashboard-server.php |
Adds Neve plan validation and tailored errors. |
LicenseField.js |
Reloads only after successful operations. |
test-dashboard-server-license.php |
Tests activation, deactivation, and validation responses. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":464.7,"q50":477.8,"q75":507.9,"cnt":10}, firstPaint: {"q25":1545.91,"q50":1758.43,"q75":1971.17,"cnt":10}, domContentLoaded: {"q25":4363,"q50":4378.14,"q75":4407.71,"cnt":10}, loaded: {"q25":4366.68,"q50":4382.17,"q75":4411.74,"cnt":10}, firstContentfulPaint: {"q25":2689.88,"q50":3046.64,"q75":3313.37,"cnt":10}, firstBlock: {"q25":21102.8,"q50":21545.05,"q75":21764.89,"cnt":10}, type: {"q25":36.17,"q50":39.68,"q75":54.16,"cnt":10}, typeWithoutInspector: {"q25":34.8,"q50":39.19,"q75":42.34,"cnt":10}, typeWithTopToolbar: {"q25":46.02,"q50":48.37,"q75":50.21,"cnt":10}, typeContainer: {"q25":18.86,"q50":19.98,"q75":23.38,"cnt":10}, focus: {"q25":174.65,"q50":178.47,"q75":182.39,"cnt":10}, inserterOpen: {"q25":55.85,"q50":57.52,"q75":58.93,"cnt":10}, inserterSearch: {"q25":35.9,"q50":38.02,"q75":40.32,"cnt":10}, inserterHover: {"q25":6.84,"q50":7.12,"q75":7.96,"cnt":20}, loadPatterns: {"q25":2243.29,"q50":2259.28,"q75":2305.96,"cnt":10}, listViewOpen: {"q25":291.71,"q50":295.56,"q75":302.96,"cnt":10} |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
tests/test-dashboard-server-license.php:14
- This class defines
OTTER_PRO_BASEFILEinset_up_before_class(), but PHP constants cannot be removed during teardown. Because PHPUnit normally runs the suite in one process, every later test will incorrectly observe Otter Pro's base file as defined, making results order-dependent (production code branches on this constant, e.g.inc/class-main.php:618). Isolate this class so the fixture cannot leak into the rest of the suite.
class Test_Dashboard_Server_License extends WP_UnitTestCase {
Soare-Robert-Daniel
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2983
Summary
Validated the invalid license key message when the provided license key is not in the Neve allowlist.
Checklist before the final review