Feat/performance recommended plugins - #4577
Open
harshitarora-in wants to merge 5 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-incomplete
Collaborator
There was a problem hiding this comment.
Pull request overview
Adds promoted performance-plugin recommendations to the Dashboard Settings Performance tab.
Changes:
- Adds Optimole and Super Page Cache cards with install/activation actions.
- Adds loading, success, error, and telemetry handling.
- Updates the settings layout to display recommendations below performance settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
assets/apps/dashboard/src/Components/Content/Settings/PerformancePlugins.js |
Implements promoted plugin cards and action states. |
assets/apps/dashboard/src/Components/Content/Settings.js |
Integrates the recommendations into the Performance tab. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
+40
| if (isPluginActive && !success) { | ||
| return null; | ||
| } |
Co-authored-by: harshitarora-in <56164789+harshitarora-in@users.noreply.github.com>
abaicus
requested changes
Aug 17, 2026
Copilot stopped work on behalf of
harshitarora-in due to an error
August 18, 2026 11:49
Move PerformancePlugins into PerformanceTabContent so it reuses the tab's existing conditional and TransitionWrapper, instead of duplicating both in Settings.js. Nested inside the settings card, the component's own Card rendered a white box inside a white box, so add a `flat` variant to Card that keeps the header but drops the box styling. It defaults to false, leaving the other 20 usages unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
abaicus
requested changes
Aug 24, 2026
Comment on lines
+142
to
+165
| <div className="grow flex flex-col gap-6"> | ||
| <Card> | ||
| {tab === 'general' && ( | ||
| <TransitionWrapper> | ||
| <GeneralTabContent /> | ||
| </TransitionWrapper> | ||
| )} | ||
| {tab === 'performance' && ( | ||
| <TransitionWrapper> | ||
| <PerformanceTabContent /> | ||
| </TransitionWrapper> | ||
| )} | ||
| {tab === 'white-label' && ( | ||
| <TransitionWrapper> | ||
| <WhiteLabelTabContent /> | ||
| </TransitionWrapper> | ||
| )} | ||
| {tab === 'manage-modules' && ( | ||
| <TransitionWrapper> | ||
| <ManageModulesTabContent /> | ||
| </TransitionWrapper> | ||
| )} | ||
| </Card> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
We're adding some classes here that would manage the layout inside the Performance tab content. If it's only related to that, the layout should live there. Otherwise it can have side-effects or impact on the other tabs content. We should wrap the Content inside the PerformanceTabContent component in a div or add the needed classes on its main wrapper. Otherwise I don't see why we can't simply add a mt-6 class on the PerformancePlugins component.
Later Edit: It looks like we already have a mt-6 class there, so why do we still need changes here?
Render the promoted plugins block with the existing ControlWrap section primitive instead of a nested Card. Settings.js and Layout/Card.js return to their original state; the section spacing and divider now come from the same rhythm the other settings sections use. PerformancePlugins owns the visible list and shrinks it when a card is dismissed, so the section unmounts once the last card is gone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Comment on lines
+119
to
+127
| const [visibleSlugs, setVisibleSlugs] = useState(() => | ||
| PROMOTED_SLUGS.filter((slug) => { | ||
| // Super Page Cache is dropped server side when SPC Pro is | ||
| // installed, so a promoted slug can be missing entirely. | ||
| const plugin = neveDash.plugins[slug]; | ||
|
|
||
| return plugin && plugin.cta !== 'deactivate'; | ||
| }) | ||
| ); |
Comment on lines
+148
to
+155
| {visibleSlugs.map((slug) => ( | ||
| <PluginCard | ||
| key={slug} | ||
| slug={slug} | ||
| data={neveDash.plugins[slug]} | ||
| onDismiss={handleDismiss} | ||
| /> | ||
| ))} |
Comment on lines
+91
to
+99
| {!success && ( | ||
| <button | ||
| onClick={handleClick} | ||
| disabled={loading} | ||
| className={cn( | ||
| 'mt-3 self-start text-blue-600 hover:text-blue-700 text-sm font-medium flex items-center', | ||
| { 'opacity-75 cursor-not-allowed': loading } | ||
| )} | ||
| > |
Comment on lines
+35
to
+47
| useEffect(() => { | ||
| if (!success) { | ||
| return; | ||
| } | ||
|
|
||
| // Only `success` belongs in the deps: onDismiss is recreated on every | ||
| // parent render and would restart a countdown already in progress. | ||
| const timeoutId = window.setTimeout(() => { | ||
| onDismiss(slug); | ||
| }, ACTIVE_PILL_TIMEOUT); | ||
|
|
||
| return () => window.clearTimeout(timeoutId); | ||
| }, [success]); |
| const handleClick = async () => { | ||
| setError(null); | ||
|
|
||
| window.tiTrk?.with('neve').set(slug, { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new Recommended Plugins section in the Dashboard Settings Performance tab.
It introduces plugin cards for:
Behavior included:
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/neve-pro-addon/issues/3027