Skip to content

fix(percipioTheme): update border-secondary from navy-200 to navy-600#3372

Closed
LinKCoding wants to merge 1 commit into
mainfrom
kl-percipio-theme-border
Closed

fix(percipioTheme): update border-secondary from navy-200 to navy-600#3372
LinKCoding wants to merge 1 commit into
mainfrom
kl-percipio-theme-border

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Overview

update border-secondary from navy-200 to navy-600 for better contrast

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

N/A

@Codecademy Codecademy deleted a comment from CLAassistant Jun 15, 2026
@LinKCoding LinKCoding closed this Jun 15, 2026
@nx-cloud

nx-cloud Bot commented Jun 15, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f3d6fbd


☁️ Nx Cloud last updated this comment at 2026-06-15 14:00:25 UTC

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 71.0.1-alpha.ca93a8.0 npm diff
@codecademy/gamut-icons 9.57.8-alpha.ca93a8.0 npm diff
@codecademy/gamut-illustrations 0.58.14-alpha.ca93a8.0 npm diff
@codecademy/gamut-kit 2.0.1-alpha.ca93a8.0 npm diff
@codecademy/gamut-patterns 0.10.33-alpha.ca93a8.0 npm diff
@codecademy/gamut-styles 20.0.1-alpha.ca93a8.0 npm diff
@codecademy/gamut-tests 6.0.4-alpha.ca93a8.0 npm diff
@codecademy/variance 0.26.2-alpha.ca93a8.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.ca93a8.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1331 1 1330 0
View the top 1 failed test(s) by shortest run time
themes percipio - theme shape
Stack Traces | 0.005s run time
Error: expect(received).toMatchSnapshot()

Snapshot name: `themes percipio - theme shape 1`

- Snapshot  - 3
+ Received  + 3

@@ -140,11 +140,11 @@
          "background-selected": "rgba(16,22,47,0.04)",
          "background-success": "#EEF7F3",
          "background-warning": "#FFF7E0",
          "border-disabled": "rgba(16,22,47,0.28)",
          "border-primary": "rgba(16,22,47,0.47)",
-         "border-secondary": "rgba(16,22,47,0.12)",
+         "border-secondary": "rgba(16,22,47,0.75)",
          "border-tertiary": "#10162F",
          "danger": "#B83C3C",
          "danger-hover": "#A52020",
          "feedback-error": "#B83C3C",
          "feedback-success": "#1B8057",
@@ -177,11 +177,11 @@
        "--color-background-selected": "var(--color-navy-100)",
        "--color-background-success": "var(--color-percipioBgSuccess)",
        "--color-background-warning": "var(--color-percipioBgWarning)",
        "--color-border-disabled": "var(--color-navy-300)",
        "--color-border-primary": "var(--color-navy-400)",
-       "--color-border-secondary": "var(--color-navy-200)",
+       "--color-border-secondary": "var(--color-navy-600)",
        "--color-border-tertiary": "var(--color-navy-800)",
        "--color-danger": "var(--color-percipioDanger)",
        "--color-danger-hover": "var(--color-percipioActionDangerHover)",
        "--color-feedback-error": "var(--color-percipioDanger)",
        "--color-feedback-success": "var(--color-percipioFeedbackSuccess)",
@@ -520,11 +520,11 @@
        "background-selected": "navy-100",
        "background-success": "percipioBgSuccess",
        "background-warning": "percipioBgWarning",
        "border-disabled": "navy-300",
        "border-primary": "navy-400",
-       "border-secondary": "navy-200",
+       "border-secondary": "navy-600",
        "border-tertiary": "navy-800",
        "danger": "percipioDanger",
        "danger-hover": "percipioActionDangerHover",
        "feedback-error": "percipioDanger",
        "feedback-success": "percipioFeedbackSuccess",
    at .../themes/__tests__/theme.test.ts:14:54
    at Object.<anonymous> (.../jest-each/build/bind.js:81:13)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at async _runTest (.../jest-circus/build/run.js:252:3)
    at async _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at async _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at async run (.../jest-circus/build/run.js:71:3)
    at async runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at async jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at async runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at async runTest (.../jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants