Skip to content

chore!: remove AccordionDeprecated and related types and components #3366

Merged
LinKCoding merged 7 commits into
mainfrom
kl-gmt-1622-accordiondep-cleanup
Jun 15, 2026
Merged

chore!: remove AccordionDeprecated and related types and components #3366
LinKCoding merged 7 commits into
mainfrom
kl-gmt-1622-accordiondep-cleanup

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Overview

Removes the deprecated accordion stack from @codecademy/gamut:

  • AccordionDeprecated
  • AccordionAreaDeprecated
  • AccordionButtonDeprecated
  • Internal ButtonDeprecated (not publicly exported)

Also removes related Storybook docs and updates the export snapshot test.

Breaking change: Consumers should migrate to Disclosure (or List with expandable rows for multiple accordions).

PR Checklist

  • Related to designs: N/A — removal only, no new UI
  • Related to JIRA ticket: GMT-1622
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. See that tests pass
  2. Checkout Storybook and see that AccordionDeprecated, AccordionAreaDeprecated, and AccordionButtonDeprecated no longer have stories
  3. See that these components, and ButtonDeprecated are not exported and no longer part of the codebase
  4. ...
  5. Celebrate

PR Links and Envs

Repository PR Link
Monolith PR
Mono PR

@LinKCoding LinKCoding changed the title first go at removing AccordionDep and related components chore!: remove AccordionDeprecated and related types and components Jun 4, 2026
@nx-cloud

nx-cloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e83f580


☁️ Nx Cloud last updated this comment at 2026-06-15 17:06:21 UTC

@nx-cloud

nx-cloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 63af23a


☁️ Nx Cloud last updated this comment at 2026-06-04 14:11:48 UTC

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (01f581f) to head (e83f580).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   90.38%   90.26%   -0.13%     
==========================================
  Files         403      377      -26     
  Lines        6638     6186     -452     
  Branches     2149     1991     -158     
==========================================
- Hits         6000     5584     -416     
+ Misses        630      594      -36     
  Partials        8        8              
Flag Coverage Δ
main ?
pull-request 90.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1,6 +1,6 @@
# 2.0.0 (2026-06-04)

### ⚠️ Breaking Changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely sure how this extra space was added into main, but locally I can't remove it since husky keeps linting the files and removing the space even when I add it back in manually. so 🤷 nbd imo, but can look more into it if anyone has a strong opinion

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that has happened to me to, its so weird

@LinKCoding LinKCoding marked this pull request as ready for review June 9, 2026 14:28
@LinKCoding LinKCoding requested a review from a team as a code owner June 9, 2026 14:28
@LinKCoding LinKCoding requested a review from dreamwasp June 15, 2026 15:11

@dreamwasp dreamwasp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me!! do you know whats up with the prettier tweaks? they're harmless its just weird, i'd remove them but don't have a strong feeling either way.

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 71.0.1-alpha.d92614.0 npm diff
@codecademy/gamut-icons 9.57.8-alpha.d92614.0 npm diff
@codecademy/gamut-illustrations 0.58.14-alpha.d92614.0 npm diff
@codecademy/gamut-kit 2.0.1-alpha.d92614.0 npm diff
@codecademy/gamut-patterns 0.10.33-alpha.d92614.0 npm diff
@codecademy/gamut-styles 20.0.1-alpha.d92614.0 npm diff
@codecademy/gamut-tests 6.0.4-alpha.d92614.0 npm diff
@codecademy/variance 0.26.2-alpha.d92614.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.d92614.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding merged commit 17e0765 into main Jun 15, 2026
16 checks passed
@LinKCoding LinKCoding deleted the kl-gmt-1622-accordiondep-cleanup branch June 15, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants