chore!: remove AccordionDeprecated and related types and components #3366
Conversation
|
View your CI Pipeline Execution ↗ for commit e83f580 ☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 63af23a ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3366 +/- ##
==========================================
- Coverage 90.38% 90.26% -0.13%
==========================================
Files 403 377 -26
Lines 6638 6186 -452
Branches 2149 1991 -158
==========================================
- Hits 6000 5584 -416
+ Misses 630 594 -36
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -1,6 +1,6 @@ | |||
| # 2.0.0 (2026-06-04) | |||
|
|
|||
| ### ⚠️ Breaking Changes | |||
There was a problem hiding this comment.
not entirely sure how this extra space was added into main, but locally I can't remove it since husky keeps linting the files and removing the space even when I add it back in manually. so 🤷 nbd imo, but can look more into it if anyone has a strong opinion
There was a problem hiding this comment.
that has happened to me to, its so weird
dreamwasp
left a comment
There was a problem hiding this comment.
this looks good to me!! do you know whats up with the prettier tweaks? they're harmless its just weird, i'd remove them but don't have a strong feeling either way.
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a3031b4188c80f6bea9570a--gamut-preview.netlify.app |
Overview
Removes the deprecated accordion stack from
@codecademy/gamut:AccordionDeprecatedAccordionAreaDeprecatedAccordionButtonDeprecatedButtonDeprecated(not publicly exported)Also removes related Storybook docs and updates the export snapshot test.
Breaking change: Consumers should migrate to
Disclosure(orListwith expandable rows for multiple accordions).PR Checklist
Testing Instructions
AccordionDeprecated,AccordionAreaDeprecated, andAccordionButtonDeprecatedno longer have storiesButtonDeprecatedare not exported and no longer part of the codebasePR Links and Envs