London | 26-ITP-May | Rhoda Ajiroba | Sprint 1|Form Controls#1419
Open
codebyra wants to merge 8 commits into
Open
London | 26-ITP-May | Rhoda Ajiroba | Sprint 1|Form Controls#1419codebyra wants to merge 8 commits into
codebyra wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
codebyra
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Jun 6, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
| id="name" | ||
| name="name" | ||
| required | ||
| pattern=".*\S.*\S.*" |
| } | ||
|
|
||
| form { | ||
| max-width: 400px; |
There was a problem hiding this comment.
The styling looks quite nice. A small detail that you could improve (but don't have to) is to take a look at the text inputs. They are overflowing the form border a bit
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR adds the completed Form Controls exercise.
It includes:
A customer details section with validated name + email fields
A T‑shirt options section with exactly 3 colours and 6 sizes
All fields marked as required
No JavaScript used
Basic CSS styling for layout and readability
HTML and CSS updated to pass W3C validation