West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 1 | Form Controls#1414
Open
maryam-devio wants to merge 5 commits into
Open
West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 1 | Form Controls#1414maryam-devio wants to merge 5 commits into
maryam-devio wants to merge 5 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
maryam-devio
added
the
Needs Review
jayshreehajgude2012
added
Review in progress
jayshreehajgude2012
left a comment
jayshreehajgude2012
left a comment
There was a problem hiding this comment.
check opening and closing tags.
validation used.
Try to add autocomplete property.
Provide default selection for options.
| this will also help you fill in your PR message later--> | ||
| <!--Customer Name--> | ||
| <label for="name">Name</label> | ||
| <input |
| required pattern=".*\S.*\S.*" | ||
| /> | ||
| <!--Customer Email--> | ||
| <label for="email">Email</label> |
There was a problem hiding this comment.
correct input type used and validation done
|
|
||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> |
| @@ -13,15 +20,54 @@ <h1>Product Pick</h1> | |||
| </header> | |||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required pattern=".*\S.*\S.*" |
There was a problem hiding this comment.
can you provide simple validation pattern for the same.
| /> | ||
| <fieldset> | ||
| <!--Select T-shirt colour--> | ||
| <legend>Choose T-shirt Colour</legend> |
| <fieldset> | ||
| <!--Select T-shirt colour--> | ||
| <legend>Choose T-shirt Colour</legend> | ||
| <input type="radio" id="purple" name="colour" value="purple" required> |
jayshreehajgude2012
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Your PR description is incomplete. You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page. Make sure to fill in all fields in the template. Please ensure:
If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist