Birmingham|26-ITP-May|Yonas Gebre|Sprint 2|Wireframe#1412
Open
yonasdesbelegebre wants to merge 8 commits into
Open
Birmingham|26-ITP-May|Yonas Gebre|Sprint 2|Wireframe#1412yonasdesbelegebre wants to merge 8 commits into
yonasdesbelegebre wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yonasdesbelegebre
added
the
Needs Review
akeren
added
📅 Sprint 2
akeren
reviewed
Jun 5, 2026
akeren
left a comment
akeren
left a comment
There was a problem hiding this comment.
@yonasdesbelegebre, your codebase is well-structured. However, the root directory of your project has a lot of files.
How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?
akeren
added
Reviewed
Author
Thank you for the feedback, I will create folders for images and the pages. |
yonasdesbelegebre
added
Needs Review
akeren
reviewed
Jun 6, 2026
| <li>Experimenting with ideas</li> | ||
| </ul> | ||
|
|
||
| <a href="branch_git.html">Read more</a> |
There was a problem hiding this comment.
@yonasdesbelegebre, why is this anchor link returning a not found error?
Comment on lines
+55
to
73
| } | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
|
|
||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| height: 60px; | ||
| background-color:#4D4D4D; | ||
| color: #fff; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| bottom: 0; | ||
| } | ||
| footer a { | ||
| color: #fff; | ||
| text-decoration: none; | ||
| } |
There was a problem hiding this comment.
@yonasdesbelegebre, how could you make the separation between blocks of code clearer?
akeren
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Based on the Wireframe, I have created the Title for the article and small explanation about the page.
The wireframe have 3 articles, one on top and other two side by side.
These article contains images, title and content as well as the link to read more page.
The footer is about who developed the page and how they contact us.