Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 2 | Wireframe to Web Code#1409
Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 2 | Wireframe to Web Code#1409fromonda wants to merge 5 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fromonda
added
the
Needs Review
akeren
added
📅 Sprint 2
akeren
left a comment
akeren
left a comment
There was a problem hiding this comment.
@fromonda, your codebase structure is currently simple and easy to follow, with files kept in the same root directory.
- As your projects grow, what might happen if you later add more
CSS files,JavaScript files,images, or multipleHTML pages? - How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| Built using semantic HTML, CSS layout techniques, and version control | ||
| practices. | ||
| </p> | ||
| </footer> |
There was a problem hiding this comment.
@fromonda, examine the footer position in the rendered UI. Where should it sit relative to the rest of the page, and what styling might need to change?
There was a problem hiding this comment.
The footer was intentionally anchored to the bottom of the viewport using position: fixed. However, based on your comment, I understood that the footer would be better positioned below the page content so that it follows the normal document flow. I have therefore removed the fixed positioning and allowed the footer to sit naturally after the main content.
There was a problem hiding this comment.
@fromonda, how about the alignment of the footer position?
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| <p>Learn about README files, wireframes, and Git branches.</p> | ||
| </header> |
There was a problem hiding this comment.
@fromonda, when you compare the header with the main body, does the UI alignment look intentional? What CSS change might help align them?
There was a problem hiding this comment.
The alignment between the header and the main body was not intentional; it was simply the default behaviour. From your comment, I understood that you were suggesting a more consistent alignment, so I applied the same container styling used for the main body to the header as well.
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
There was a problem hiding this comment.
@fromonda, could you explain why you've added this empty line?
There was a problem hiding this comment.
The empty line you mentioned, along with the others I added, is intended to make the code more readable by visually separating the different sections. In this case, it helps distinguish the head snippet from the body snippet, while the others separate the individual article snippets, making the structure easier to read.
There was a problem hiding this comment.
@fromonda, you could use the prettier or eslint extension plugins to help with code formatting. It'll be more consistent and automatic.
akeren
added
Reviewed
fromonda
added
Needs Review
@fromonda, what about this comment? |
2 participants
Self checklist
Changelist