Birmingham | 25-ITP-May | Tobias Amaechina|Sprint 1|Form control#1324
Birmingham | 25-ITP-May | Tobias Amaechina|Sprint 1|Form control#1324Tobias-Amaechina wants to merge 17 commits into
Conversation
…ing arial-describedby to aria-describedby in the fistname, last name and email, password input element
…me, email and password
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
|
@Tobias-Amaechina please read through the issues the GitHub bot has raised and correct your PR template. You need to add a Label (right hand side of this page) titled "Needs Review" to submit this work for review. You will only be able to do that when the github bot doesn't find issues with the PR template |
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
|
I have added the needs review label |
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Please have a look at the lighthouse check. How could you get to a 100?
| <input type="email" id="email" name="email" required pattern="[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,}$" | ||
| aria-describedby="emailHelp"> |
There was a problem hiding this comment.
I find the code hard to read because of the formatting (long lines). How can you ensure consistent formatting in your code?
There was a problem hiding this comment.
Thank you for the review and the feedback , I have made the long lines shorted and have installed prettier for consistent formatting
Thanks
| <!-- First name--> | ||
| <fieldset> | ||
| <label for = "first-name">First Name</label> | ||
| <input type="text" id="first-name" name="first-name" required pattern=".*\S.*\S.*" |
There was a problem hiding this comment.
Good job on the validation. This works well
Luro91
removed
the
Needs Review
Luro91
added
Reviewed
…round colour from white to black this correction whas due to error message from lighthouse
|
Thank you for the review and the feedback , I have actioned the feedback . |
Tobias-Amaechina
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
I see an accessibility score of 95 in Lighthouse. How can you get it to 100?
| <label for ="password">Password</label> | ||
| <input type="password" id="password" name="password" | ||
| required pattern="^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[@$!%*?&])[A-Za-z\d@$!%*?&]{8,}$" | ||
| aria-describedby="passwordHelp"> | ||
| <small id="passwordHelp"> | ||
| Must be at least 8 characters long and include at least one uppercase letter, | ||
| one lowercase letter, | ||
| one number, and one special character</small> | ||
| </fieldset> |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
Luro91
removed
the
Needs Review
3 participants
Learners, PR Template
Self checklist
Changelist
I have completed the Form Control assignment. The form collects customer information with the following fields:
2.Customer Email: Email input with validation for proper email format
4.T-Shirt Size: Dropdown menu with 6 options (XS, S, M, L, XL, XXL)
All form inputs are properly validated and the form meets the assignment requirements.
I agree to follow the code of conduct for this organisation