London | 26-ITP-May | Daniel Mears | Sprint 1 | Form Controls#1261
Open
djmears-dev wants to merge 5 commits into
Open
London | 26-ITP-May | Daniel Mears | Sprint 1 | Form Controls#1261djmears-dev wants to merge 5 commits into
djmears-dev wants to merge 5 commits into
Conversation
djmears-dev
commented
May 13, 2026
djmears-dev
commented
- I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
- My changes meet the requirements of the task
- I have tested my changes
- My changes follow the style guide
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
djmears-dev
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 14, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
When I run lighthouse in Google chrome I don't get a score of 100. How did you test this?
|
|
||
| <label for="name">Customer Name:</label> | ||
|
|
||
| <input |
There was a problem hiding this comment.
I find the code hard to read because of the formatting (indentation). How can you ensure consistent formatting in your code?
Author
There was a problem hiding this comment.
Hi i've now formatted the code using prettier to make it more readable, i have also assured that the lighthouse accessibility is 100
Comment on lines
+24
to
+33
| pattern=".*\S.{1,}.*" | ||
| > | ||
| <br><br> | ||
| <label for="email">Email Address:</label> | ||
|
|
||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="email" | ||
| required |
There was a problem hiding this comment.
Good job on the validations and making things required
Luro91
added
Reviewed
djmears-dev
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Jun 6, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
Comment on lines
+41
to
+56
| <input type="radio" id="xs" name="size" value="XS" required /> | ||
| <label for="xs">XS</label> | ||
|
|
||
| <input type="radio" id="s" name="size" value="S" /> | ||
| <label for="s">S</label> | ||
|
|
||
| <input type="radio" id="m" name="size" value="M" /> | ||
| <label for="m">M</label> | ||
|
|
||
| <input type="radio" id="l" name="size" value="L" /> | ||
| <label for="l">L</label> | ||
|
|
||
| <input type="radio" id="xl" name="size" value="XL" /> | ||
| <label for="xl">XL</label> | ||
|
|
||
| <input type="radio" id="xxl" name="size" value="XXL" /> |
There was a problem hiding this comment.
FYI: I would switch around the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.