Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Quote generator - #1413
Open
KhotKeys wants to merge 2 commits into
Open
Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Quote generator#1413KhotKeys wants to merge 2 commits into
KhotKeys wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
KhotKeys
force-pushed
the
sprint-3-quote-generator
branch
from
August 9, 2026 14:13
cc5c91a to
6968115
Compare
KhotKeys
added
🏕 Priority Mandatory
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, some suggested areas to look at
| #new-quote { | ||
| margin: 20px; | ||
| position: absolute; | ||
| left: 50%; |
There was a problem hiding this comment.
Did you mean to center this button? It's not quite exactly centre, can you figure out how to fix that?
Author
There was a problem hiding this comment.
I see! The extra margin: 20px was fighting with the left: 50% transformation, throwing off the center alignment. I've stripped out the absolute positioning and refactored it using block margins (margin: 20px auto) to make it perfectly centered.
| </head> | ||
| <body> | ||
| <h1>hello there</h1> | ||
| <p id="quote"></p> |
There was a problem hiding this comment.
Is there a semantic html element you could use here?
Author
There was a problem hiding this comment.
Surely, I have applied blockquote and cite
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented displayQuote to pick a random quote from the quotes array using pickFromArray and update the #quote and #author elements.
Called displayQuote on page load for the initial display and wired it to the #new-quote button click event.