London | 26-ITP-May | Vito Moratti | Sprint 3 | Alarm-clock - #1384
Open
vmoratti wants to merge 6 commits into
Open
London | 26-ITP-May | Vito Moratti | Sprint 3 | Alarm-clock#1384vmoratti wants to merge 6 commits into
vmoratti wants to merge 6 commits into
Conversation
vmoratti
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 8, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
- If the user clicks "Stop Alarm" before the timer reaches 00:00, what happens to the countdown? Will the alarm still ring when the timer finishes?
- Could formatTime() do its job by returning the formatted time instead of relying on and updating global variables?
hey-hammad
added
Reviewed
Refactor formatTime function to accept remainingSeconds as a parameter and return formatted time string. Update alarm display logic to use the new formatTime function.
Author
|
I have now made the recommended adjustments. |
vmoratti
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed implementation of the alarm clock