London | 26-ITP-May | Damilola Odumosu| Sprint 3 | ToDo List - #1383
Open
d-odumosu wants to merge 1 commit into
Open
London | 26-ITP-May | Damilola Odumosu| Sprint 3 | ToDo List#1383d-odumosu wants to merge 1 commit into
d-odumosu wants to merge 1 commit into
Conversation
d-odumosu
added
Needs Review
LonMcGregor
reviewed
Aug 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, the todolist works, but I have some questions about the code style used
| // Set up tasks to be performed once on page load | ||
| window.addEventListener("load", () => { | ||
| document.getElementById("add-task-btn").addEventListener("click", addNewTodo); | ||
| document.getElementById("delete-btn").addEventListener("click", (e) => { |
There was a problem hiding this comment.
The above event listener uses a named function rather than an anonymous function, could you make these consistent?
| export function deleteCompleted(todoList) { | ||
| const incompleteTodos = todoList.filter((todo) => !todo.completed); | ||
| todoList.length = 0; //empty the original array | ||
| todoList.push(...incompleteTodos); //push incompleted task |
There was a problem hiding this comment.
Here you seem to be overriding the todoList with some new values - What is your reasoning for doing it this way with setting length to zero then pushing? Are there any alternative ways of achieving this?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
added functionality to delete all completed todos
added new button
implemented jest test