London | 26-ITP-May | Jorvan White | Sprint 3 | Alarm Clcok - #1382
Open
JorvanW wants to merge 26 commits into
Open
London | 26-ITP-May | Jorvan White | Sprint 3 | Alarm Clcok#1382JorvanW wants to merge 26 commits into
JorvanW wants to merge 26 commits into
Conversation
added 22 commits
July 20, 2026 19:32
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Note: a user may not click the "Stop" button first before starting a new count down.
Comment on lines
+10
to
+13
| if (seconds <= 0 || isNaN(seconds)) { | ||
| alert("Please enter a valid number."); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
What type of number should seconds be?
| </head> | ||
| <body> | ||
| <div class="centre"> | ||
| <h1 id="timeRemaining">Time Remaining: 00:00</h1> |
Contributor
There was a problem hiding this comment.
Could consider replacing
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
by
<div id="timeRemaining">Time Remaining: <span id="theTime">00:00</span></div>
and update only the content of the element #theTime in JS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Created Pull Request from Sprint 3 Task and updated for Pull Request