Skip to content

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | ToDo List - #1379

Open
khaliun-dev wants to merge 4 commits into
CodeYourFuture:mainfrom
khaliun-dev:sprint-3/todo-list
Open

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | ToDo List#1379
khaliun-dev wants to merge 4 commits into
CodeYourFuture:mainfrom
khaliun-dev:sprint-3/todo-list

Conversation

@khaliun-dev

@khaliun-dev khaliun-dev commented Aug 5, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • added functionality to delete all completed todos
  • added new button to the UI
  • wrote new tests and verified if the feature works
  • passed all the tests

Questions

None.

@khaliun-dev khaliun-dev added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 5, 2026
LonMcGregor
LonMcGregor reviewed Aug 10, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this task, I have one minor comment

Comment thread Sprint-3/todo-list/script.mjs Outdated
document
.getElementById("delete-completed-btn")
.addEventListener("click", () => {
Todos.deleteCompleted(todos);

@LonMcGregor LonMcGregor Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above event listener uses a named function rather than an anonymous function, could you make these consistent?

@khaliun-dev khaliun-dev Aug 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LonMcGregor , made it consistent, thanks!

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 10, 2026
@khaliun-dev khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
LonMcGregor
LonMcGregor reviewed Aug 11, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is much more consistent now. task complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khaliun-dev @LonMcGregor