London | 26-ITP-May | Vito Moratti | Sprint 3 | Quote generator - #1376
London | 26-ITP-May | Vito Moratti | Sprint 3 | Quote generator#1376vmoratti wants to merge 3 commits into
Conversation
vmoratti
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, some areas could be improved
| </header> | ||
| <main> | ||
| <section> | ||
| <p id="quote"></p> |
There was a problem hiding this comment.
good use of a main and section, is there any semantic html you could use for the quote content itself?
There was a problem hiding this comment.
I have replaced
with
which is more semantic/ appropriate
There was a problem hiding this comment.
I don't know what happened there with the comment. ....
I replaced paragraph tags with blockquote.
|
|
||
| function newQuoteEveryTime() { | ||
| const quote = pickFromArray(quotes); | ||
| const quotePlace = document.querySelector("#quote"); |
There was a problem hiding this comment.
Is there a reason you have duplicate querySelectors?
There was a problem hiding this comment.
I thought there was a reason initially, but now i replaced those four variables with just two.
There was a problem hiding this comment.
On my device, the browser shows a scrollbar here that isn't necessary, can you figure out why?
LonMcGregor
added
Reviewed
…nge <p> to <blockquote in Html
vmoratti
added
the
Needs Review
2 participants
Self checklist
Changelist
Complete Quote-generator.
Questions
I couldn't attempt stretch exercises unfortunately as i am behind with the other coursework.