-
-
Notifications
You must be signed in to change notification settings - Fork 326
London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Alarm Clock App #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
russom-g
wants to merge
50
commits into
CodeYourFuture:main
Choose a base branch
from
russom-g:sprint-3/alarmclock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
c9145df
CalculateMedian function implemented
1cf01db
Comment updated on return null
256ef50
Function calculateMedian updated so it could calculate even elements …
84b5c1e
.houseNumber added in order to the house number to be printed.
51f62a2
Author object for of loop changed into for in tp print al the values …
ae0b900
Recipe object literal fixed so it can prints the ingredients on new l…
702b5ba
A fifth element removed from ingredients array which was unneeded
583bb2c
Tests created for all cases.
c0f9787
function implemented for checking property exist in an object.
552c68c
Initial test case created
9058a37
Function implemented for creating an abject from key-value array.
ce06e18
Spelling mistakes and bug in CA key fixed. Test passes.
e6267ac
Missing return obj added.
14c848c
Commented unneeded code deleted.
c66861d
First test values containing = tested
c4dec19
the for loop for testing values containing = fixed
d5c28aa
If !pair added for checking empty strings.
b10058d
decodeURLComponent function used to decode percent-encoded characters…
7fc4886
Using a regular expression .replace(/\+/g, " ") the + sign is remove…
946461b
Last test commented out
37e70cb
Test created for all the cases
1b4063a
function implemented for checking duplicate items.
af59161
for the last test for invalid input test adjusted so jest can check f…
0877d2d
if statement added to check the item is number not string.
ab84c24
the tittle element changed into Quote generator app"
57bcdde
showRandomQuote function implemented to display randomised quote upon…
6100dc9
showRandomQuote function implemented to display randomised quote upon…
1ca1d5e
hello there changed to welcome on h1 element
1547e5b
Simple changes made to the styling
e72732e
"Delete completed tasks" button added.
f997781
Delete completed function started being implemented
d674f5c
comment added
81f7863
Title element updated to 'Alarm clock app'
27fa3e9
Time and heading variables declared.
e0849c0
Minutes and seconds declared. heading.innerText changed to include re…
e16e1b0
setIntervals timer started. Minutes and seconds recalculated again.
6e2d741
if condition for checking count down is zero. Then paly the alarm and…
b7754d4
Errors fixed
7ea21cf
Typos and errors in the code corrected.
a9865b0
Restore files accidentally removed from branch
43fcdea
Remove files that don't belong in this PR
24e00dc
Remove package.json from tracking, keep locally
f3c7417
Ignore local package.json
3cddd7d
Remove unnecessary root package.json
0497772
Revert .gitignore change
c1f876a
Restore package.json to match main
3dbc4ad
Minor formatting touch
41e8658
update: add if condition for checking invalid numbers
b92e1e2
refactor: implement updateDisplay to reuse its code
4827e04
fix: reset timer and audio before setting another alarm
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,4 @@ | |
| }, | ||
| "homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,4 @@ | |
| h1 { | ||
| text-align: center; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of number should
timebe?