Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 3 | Quote Generator App - #1374
Open
fromonda wants to merge 6 commits into
Open
Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 3 | Quote Generator App#1374fromonda wants to merge 6 commits into
fromonda wants to merge 6 commits into
Conversation
fromonda
added
📅 Sprint 3
tiakavousi
added
the
Review in progress
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
tiakavousi
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
fromonda
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
fromonda
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, the app functions well, but there are possible places to improve further, see my comments
|
|
||
| <!-- Inner white card --> | ||
| <div class="quote-box"> | ||
| <p id="quote"></p> |
There was a problem hiding this comment.
Is there some semantic html you could use here, in place of multiple nested divs?
Author
There was a problem hiding this comment.
I have updated the HTML to use more semantic elements instead of multiple nested div elements.
|
|
||
| /* Quote text styling with orange quote mark added automatically */ | ||
| #quote { | ||
| color: #f3a83c; |
There was a problem hiding this comment.
When I check the accessiblity with lighthouse, it tells me there is insufficient contrast, did you spot this when testing?
Author
There was a problem hiding this comment.
I did not have time to carry out Lighthouse testing before submitting the task, as I was balancing the available time with completing the task requirements. Please bear in mind that finding this balance is an important skill to have in the workplace. However, I have now improved the contrast based on the Lighthouse feedback, and I hope that the task will still be considered complete.
LonMcGregor
added
Reviewed
fromonda
removed
the
Reviewed
fromonda
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist