Skip to content

London | May-2026-itp | Chun Yan Wong | Sprint 3 | Quote Generator - #1371

Open
cywong-dev wants to merge 6 commits into
CodeYourFuture:mainfrom
cywong-dev:sprint3-quotegenerator
Open

London | May-2026-itp | Chun Yan Wong | Sprint 3 | Quote Generator#1371
cywong-dev wants to merge 6 commits into
CodeYourFuture:mainfrom
cywong-dev:sprint3-quotegenerator

Conversation

@cywong-dev

@cywong-dev cywong-dev commented Aug 3, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide

Changelist

This PR shows the solution for the coursework for Sprint3 - Quote Generator App

@github-actions

This comment has been minimized.

@cywong-dev cywong-dev changed the title London | May-2026-itp | Vitalii Kmit | Sprint 3 | Quote Generator London | May-2026-itp | Chun Yan Wong | Sprint 3 | Quote Generator Aug 3, 2026
@github-actions

This comment has been minimized.

@cywong-dev cywong-dev added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 3, 2026
@github-actions

This comment has been minimized.

@cywong-dev cywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 3, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two sets of code in quote.js -- one set before the // DO NOT EDIT BELOW HERE marker, and one set at the end of the file. Which one do you intend to use?

Comment thread Sprint-3/quote-generator/quotes.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
Code refactoring to group newly added functions together and changing the javascript so that the special characters " and - are displayed in HTML
@cywong-dev cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 9, 2026
Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment thread Sprint-3/quote-generator/quotes.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2026
@cywong-dev cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2026
@cywong-dev cywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants