Skip to content

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 3 | Alarm Clock App #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fromonda wants to merge 5 commits into
base: main
Choose a base branch
from
+73 −2
Open

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 3 | Alarm Clock App #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee6a0e5
Implement alarm countdown functionality
fromonda Jul 31, 2026
82b6503
Updated the page title in index.html to "Alarm clock app"
fromonda Aug 3, 2026
d8afbf5
Fix stop alarm functionality and refactor alarm logic
fromonda Aug 8, 2026
d3e4dae
Add input validation for alarm duration
fromonda Aug 8, 2026
7e5ed4f
Prevent duplicate set and stop alarm calls
fromonda Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 72 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,75 @@
function setAlarm() {}
let timer;

function updateDisplay(timeRemaining, heading) {
let minutes = Math.floor(timeRemaining / 60);
let seconds = timeRemaining % 60;

heading.innerText =
"Time Remaining: " +
String(minutes).padStart(2, "0") +
":" +
String(seconds).padStart(2, "0");
}

function setAlarm() {
let input = document.getElementById("alarmSet");
let heading = document.getElementById("timeRemaining");

let timeRemaining = parseInt(input.value);

if (isNaN(timeRemaining) || timeRemaining <= 0) {
alert("Please enter a positive number of seconds.");
return;
}

clearInterval(timer);
pauseAlarm();

audio.currentTime = 0;
document.body.style.backgroundColor = "";

updateDisplay(timeRemaining, heading);

function countdown() {
timeRemaining = timeRemaining - 1;

updateDisplay(timeRemaining, heading);

if (timeRemaining <= 0) {
clearInterval(timer);
document.body.style.backgroundColor = "red";
playAlarm();
}
}

timer = setInterval(countdown, 1000);
}

function stopAlarm() {
clearInterval(timer);
pauseAlarm();
}

const setButton = document.getElementById("set");
const stopButton = document.getElementById("stop");

setButton.addEventListener(
"click",
function (event) {
event.stopImmediatePropagation();
setAlarm();
},
true
);
Comment on lines +56 to +63

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just let the original code to call setAlarm()?


stopButton.addEventListener(
"click",
function (event) {
event.stopImmediatePropagation();
stopAlarm();
},
true
);
Comment on lines +65 to +72

@cjyuan cjyuan Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the original code would call pauseAlarm(), an alternative is to add another event listener that calls only "clearInterval()", and let the original code stop the audio.


// DO NOT EDIT BELOW HERE

Expand Down
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down
Loading