Skip to content

London | May-2026-itp | Vitalii Kmit | Sprint 3 | Alarm clock #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitalii-code wants to merge 6 commits into
base: main
Choose a base branch
from
+72 −3
Open

London | May-2026-itp | Vitalii Kmit | Sprint 3 | Alarm clock #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a1925a
Set up looping alarm
Vitalii-code Aug 1, 2026
d79612d
Revert the previous change for index.html
Vitalii-code Aug 1, 2026
1e6f60f
Add setTimout and setInterval
Vitalii-code Aug 1, 2026
a2d1980
Remove setTimout to pass all tests
Vitalii-code Aug 3, 2026
6a98e1c
Change case and add check to avoid negative numbers input
Vitalii-code Aug 8, 2026
d53501a
Check if whole number
Vitalii-code Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 70 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,73 @@
function setAlarm() {}
const lengthOfAlarmSound = 20000;

let timeLeft;
let intervalID;
let timeoutID;
let display;

function setAlarm() {
stopAlarm();

// set up time
timeLeft = document.getElementById("alarmSet").value;

@hey-hammad hey-hammad Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if I set the alarm for -10 seconds?

display = document.getElementById("timeRemaining");

// validate result
const result = parseInt(timeLeft);
console.log(result);
if (isNaN(result) || result < 0 || !Number.isInteger(result)) {

@hey-hammad hey-hammad Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integer validation doesn't seem to be working as expected. What value or type is being passed to Number.isInteger()?

result stores the validated input, but is it being used anywhere after the validation?

return;
}

display.textContent = formatTime(timeLeft);

if (!intervalID) {
intervalID = setInterval(updateTimer, 1000);
}

console.log(`Alarm set for ${timeLeft} seconds`);
}

function updateTimer() {
timeLeft = timeLeft - 1;

display.textContent = formatTime(timeLeft);

if (timeLeft <= 0) {
alarmFinished();
cleanUp();
}
}

// give a time in seconds
function formatTime(seconds) {
const minutes = Math.floor(seconds / 60);
seconds = seconds % 60;

const secondsPadded = String(seconds).padStart(2, "0");
const minutesPaddded = String(minutes).padStart(2, "0");

const formattedPeconds = `Time Remaining: ${minutesPaddded}:${secondsPadded}`;
return formattedPeconds;
}

function stopAlarm() {
pauseAlarm();
cleanUp();
}

function cleanUp() {
clearInterval(intervalID);
clearTimeout(timeoutID);
timeoutID = null;
intervalID = null;
}

function alarmFinished() {
audio.loop = true;
playAlarm();
console.log("Alarm finished");
}

// DO NOT EDIT BELOW HERE

Expand Down
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down
Loading