London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Quote generator - #1363
Open
Yonatanteklemariam wants to merge 11 commits into
Open
London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Quote generator#1363Yonatanteklemariam wants to merge 11 commits into
Yonatanteklemariam wants to merge 11 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Yonatanteklemariam
changed the title
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
changed the title
Yonatanteklemariam
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 7, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
could you please try running the HTML file in the browser and check whether the button generates a new quote correctly? If the button is not working as expected, try opening the browser console and checking for any errors to help with debugging.
hey-hammad
added
Reviewed
Author
|
Author
|
Hi @hey-hammad, thanks for your feedback and I have replied to your suggestion above and request if you could take a moment to review it again. thanks |
Yonatanteklemariam
added
Needs Review
… quotes not being displayed on page load
…le-Data-Groups into Sprint-3 Merge branch 'Sprint-3' into Sprint-3 message to explain why this merge is necessary,
…ons and added flashing effect
hey-hammad
removed
the
Needs Review
hey-hammad
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
built the html, css and javascript for the quote generator app based on the instructions