Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 1 | Module-data-groups - #1358
Open
Monsur0001 wants to merge 5 commits into
Open
Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 1 | Module-data-groups#1358Monsur0001 wants to merge 5 commits into
Monsur0001 wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
📅 Sprint 1
LonMcGregor
reviewed
Aug 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work so far, one suggestion to work on
| @@ -1 +1,5 @@ | |||
| function dedupe() {} | |||
| function dedupe(arr) { | |||
| return Array.from(new Set(arr)); | |||
There was a problem hiding this comment.
A set is a good construct to use here
| } | ||
|
|
||
| // Using Math.max to find the maximum value in the numeric elements | ||
| return Math.max(...numericElements); |
There was a problem hiding this comment.
Do you think you could try to implement this without using the built-in max?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer. You must remove this section if you have no questions.