London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | Quote generator - #1355
Open
ChinweP wants to merge 18 commits into
Open
London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | Quote generator#1355ChinweP wants to merge 18 commits into
ChinweP wants to merge 18 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
ChinweP
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ChinweP
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ChinweP
added
the
Needs Review
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code could use some minor improvements but it is well written.
Comment on lines
+15
to
+17
| newQuoteBtn.addEventListener("click", () => { | ||
| displayRandomQuote(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Code that assign event listener once could also be placed inside the onload callback function.
cjyuan
added
Reviewed
…e magic number with AUTO_PLAY_INTERVAL.
ChinweP
added
the
Needs Review
cjyuan
reviewed
Aug 7, 2026
| autoToggle.addEventListener("change", () => { | ||
| if (autoToggle.checked) { | ||
| autoStatus.innerText = "auto-play:ON"; | ||
| intervalId = setInterval(displayRandomQuote, AUTO_PLAY_INTERVAL); // 5 seconds for testing |
Contributor
There was a problem hiding this comment.
If needed, this comment would be better placed where the variable is declared.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 3/Quote generator completed following readme instructions