London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | Alarm Clock by ChinweP · Pull Request #1354 · CodeYourFuture/Module-Data-Groups

ChinweP · 2026-07-31T22:42:34Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Sprint 3/Alarm clock coursework completed following readme instructions.

cjyuan

Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.

Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.

Hint: a user may not click the "Stop" button first before starting a new count down.

cjyuan · 2026-08-06T09:57:20Z

+    return `${mm}:${ss}`;
+  }
+
+  heading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`;


The time displaying code is used on lines 17, 23, and 25. As such, should the presentation logic changes in the future (e.g., change of wording), you would have to modify the code at three different places.

Why not implement a function to keep the time displaying code in once place?

cjyuan · 2026-08-06T10:01:13Z

+function stopFlashingBackground() {
+  document.body.classList.remove("flash");
+}


This function is never used.

Could consider design the function to take a Boolean parameter so that the function can be used to turn the flashing background on/off.

cjyuan · 2026-08-06T10:07:35Z

+  const input = document.getElementById("alarmSet");
+  const heading = document.getElementById("timeRemaining");
+
+  let remainingSeconds = Number(input.value);


What input should the app reject to prevent the app from behaving abnormally?

… improved flash toggle.

ChinweP · 2026-08-07T18:40:08Z

Hi @cjyuan, thank you for the helpful feedback. I've applied all the suggested changes and updated the implementation accordingly.

cjyuan

Changes look good. Just one more change needed.

cjyuan · 2026-08-07T23:29:47Z

+function resetAlarm() {
+  clearInterval(intervalId);
+  intervalId = null;
+  updateDisplay(0);
+  setFlashingBackground(false);
+}


A user may not click the "Stop" button first before starting a new count down. What else should also be reset?

Hint: When the "Stop" button is clicked, what action is performed?

ChinweP added 12 commits July 27, 2026 16:02

Fix calculateMedian implementation so it passes all tests

7d8f402

Add dedupe implementation that passes all current tests

4649963

Implement findMax and add full test coverage for all input scenarios

bb247fd

Implement sum function and add full test coverage

816b104

Refactor includes to use a for-of loop

64a2b80

Fix address lookup by using correct object property

b057112

Fix object iteration by using Object.values() instead of for-of

c76ea74

Add correct ingredient logging by looping through recipe.ingredients

1743311

Add jest tests covering all contains() acceptance criteria

5ee5409

Fix invert function and add tests for key-value swapping

03c6296

Complete alarm clock countdown and flashing background

3c5b7b9

Use jest 28 for Windows compatibility

9cf496b