Cape Town | 26-ITP-May | Shafiek Walker | Sprint 3 | Alarm Clock App - #1348
Open
shafiekwalker7861 wants to merge 3 commits into
Open
Cape Town | 26-ITP-May | Shafiek Walker | Sprint 3 | Alarm Clock App#1348shafiekwalker7861 wants to merge 3 commits into
shafiekwalker7861 wants to merge 3 commits into
Conversation
shafiekwalker7861
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2026
Comment on lines
+21
to
+22
| window.clearInterval(countdownId); | ||
|
|
Contributor
There was a problem hiding this comment.
A user may not click the "Stop" button first before starting a new count down. Are there any other application states that should also be reset?
Author
There was a problem hiding this comment.
Thank you. I updated setAlarm() to pause and rewind any existing alarm audio before starting a new countdown.
Comment on lines
+14
to
+18
| function updateTimeRemaining() { | ||
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| heading.textContent = `Time Remaining: ${formatTime(secondsRemaining)}`; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not design this function to take secondsRemaining through a parameter?
Author
There was a problem hiding this comment.
Thank you. I updated updateTimeRemaining() to receive the remaining seconds as a parameter, reducing its dependency on global state.
cjyuan
added
Reviewed
shafiekwalker7861
added
the
Needs Review
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
I think the app could also stop the countdown when the user click the "Stop Alarm" button.
cjyuan
added
Complete
Author
|
Thanks CJ,
Feedback much appreciated
…On Sat, 08 Aug 2026, 12:22 CJ Yuan, ***@***.***> wrote:
***@***.**** commented on this pull request.
Changes look good.
I think the app could also stop the countdown when the user click the
"Stop Alarm" button.
—
Reply to this email directly, view it on GitHub
<#1348?email_source=notifications&email_token=A4CDQ6R5MF7QJ6UNK3L5B6L5I35QFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBYHA3DGMBZHE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4888630994>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4CDQ6XUQ67ECOUVC3Y2PVL5I35QFAVCNFSNUABFKJSXA33TNF2G64TZHM3TSOJSGQ2TMMRUHNEXG43VMU5TKMBTGEZDQNRQHA42C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A4CDQ6W2MAQQ62WJ2HTN3ED5I35QFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBYHA3DGMBZHE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A4CDQ6SZZIWJVJBM5WHBZND5I35QFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBYHA3DGMBZHE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist