London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Quote Generator - #1340
Open
risikatpopoola wants to merge 1 commit into
Open
London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Quote Generator#1340risikatpopoola wants to merge 1 commit into
risikatpopoola wants to merge 1 commit into
Conversation
risikatpopoola
changed the title
abdishakoor-dev
added
Module-Data-Groups
risikatpopoola
added
the
Needs Review
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code is working great.
Note: It is a best practice to respect instructions like // DO NOT EDIT BELOW HERE.
Comment on lines
+507
to
+508
| quoteElement.innerText = `❝ ${randomQuote.quote}"`; | ||
| authorElement.innerText = `- ${randomQuote.author}`; //I could also use textcontent to access this |
Contributor
There was a problem hiding this comment.
The leading " and - appear to be for styling purposes. Keeping them in HTML or in CSS could make it easier to style or modify the view. This allows front-end developers to adjust the UI without changing any JavaScript code.
cjyuan
added
Complete
Contributor
|
Where is the "Changelist" section in the PR description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist