London | 26-ITP-May | Dagim Daniel | Sprint 1 | Exercises - #1337
London | 26-ITP-May | Dagim Daniel | Sprint 1 | Exercises#1337Dagim-Daniel wants to merge 3 commits into
Conversation
Dagim-Daniel
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. Most of these are working well, but it could be improved further
| @@ -1 +1,6 @@ | |||
| function dedupe() {} | |||
| function dedupe(value) { | |||
| const newDedupe = [...new Set(value)]; | |||
There was a problem hiding this comment.
Good use of sets, could the return code be simplified even further?
| const median = list.splice(middleIndex, 1)[0]; | ||
| // Filter out non-numeric values | ||
| // const numbers = list.filter((x) => typeof x === "number"); | ||
| const numbers = []; |
There was a problem hiding this comment.
Did you run the test case for this? I get an error when I try it
There was a problem hiding this comment.
it doesn't work it says list is not iterable but i run the code with out errors i checked it with console log too
| const right = numbers[middleIndex]; | ||
| return (left + right) / 2; | ||
| } | ||
| //console.log(`middleIndex: ${middleIndex}`); |
There was a problem hiding this comment.
What benefit does this code give by being commented out?
LonMcGregor
added
Reviewed
…le or not and do some cleaning -only left the comment i needed
Dagim-Daniel
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, the test is passing for me now, and the code looks cleaner. Good work
LonMcGregor
added
Complete
|
2 participants
…an suggests
Learners, PR Template
Self checklist
Changelist
All tasks under Sprint -1 is completed and i put all together as suggested