Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | Sprint/alarm-clock - #1332
Open
Tobias-Amaechina wants to merge 28 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | Sprint/alarm-clock#1332Tobias-Amaechina wants to merge 28 commits into
Tobias-Amaechina wants to merge 28 commits into
Conversation
Tobias-Amaechina
added
the
Needs Review
cjyuan
reviewed
Aug 3, 2026
cjyuan
added
Reviewed
… doesn't exceed 1 hour
…nd prevent pause after alarm
Tobias-Amaechina
added
🏕 Priority Mandatory
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+34
to
+35
| isNaN(seconds) || | ||
| !Number.isInteger(seconds) || |
Contributor
There was a problem hiding this comment.
One of these checks is redundant.
Comment on lines
+24
to
+26
| const value = input.value.trim();//trim empty string | ||
| //Check if the input is empty | ||
| if (value === "") { |
Contributor
There was a problem hiding this comment.
The code is clear and readable enough. I don't think these comments could make the code any clearer.
Comment on lines
+47
to
+48
| // Start a new countdown | ||
| startCountdown(); |
Contributor
There was a problem hiding this comment.
This comment is probably not needed.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added countdown logic (setAlarm) using setInterval
Implemented updateDisplay to show time in MM:SS format
Added flashing background when the alarm finishes
Added pause/resume functionality using a new togglePause handler
Added event listeners for Pause and Stop buttons
Ensured flashing stops when Stop is pressed
Kept all changes above the protected section and preserved starter code behaviour