London | 26-ITP-May | Dagim Daniel | Sprint 3 | Alarm clock - #1331
Open
Dagim-Daniel wants to merge 3 commits into
Open
London | 26-ITP-May | Dagim Daniel | Sprint 3 | Alarm clock#1331Dagim-Daniel wants to merge 3 commits into
Dagim-Daniel wants to merge 3 commits into
Conversation
Dagim-Daniel
added
Needs Review
cjyuan
reviewed
Aug 3, 2026
cjyuan
added
Reviewed
Dagim-Daniel
added
the
Needs Review
cjyuan
reviewed
Aug 3, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Most of the changes you made are good.
Sorry that I just noticed some more stuffs you could also improve.
Comment on lines
+26
to
+31
| let timeleft = Number(totalSeconds.value); | ||
|
|
||
| if (timeleft <= 0 || isNaN(timeleft)) { | ||
| alert("please enter a number greater than zero (0)!"); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
What type of number should the input be?
cjyuan
removed
the
Needs Review
Dagim-Daniel
added
the
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
You may want to check what your app would behave if the user enters "12.345" as input.
Comment on lines
-11
to
-14
|
|
||
| document.getElementById("stop").addEventListener("click", () => { | ||
| pauseAlarm(); | ||
| }); |
Contributor
There was a problem hiding this comment.
There is an instruction saying "DO NOT EDIT BELOW HERE" on line 63 though. :D
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
tasks under Sprint 3 alarm has been done