Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | quote-generator - #1325
Open
Tobias-Amaechina wants to merge 10 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | quote-generator#1325Tobias-Amaechina wants to merge 10 commits into
Tobias-Amaechina wants to merge 10 commits into
Conversation
…ted variables and used the getElemetById method to interact with the HTML document
…gle and status id in the HTML file
Tobias-Amaechina
added
the
Needs Review
cjyuan
reviewed
Aug 1, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
Note: It is a best practice to respect instructions like // DO NOT EDIT BELOW HERE.
Comment on lines
+512
to
+513
| quoteElement.innerText = `"${randomQuote.quote}"`; | ||
| authorElement.innerText = `- ${randomQuote.author}`; |
Contributor
There was a problem hiding this comment.
The " and - appear to be for styling purposes. Keeping them in the HTML (or in CSS) could make it easier to style or modify the view. This allows front-end developers to adjust the UI without changing any JavaScript code.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Changelist
UI Modifications: Added a switch/checkbox control and a live status indicator (auto-play: ON/OFF) to index.html.
Interval Management: Implemented setInterval and clearInterval logic inside quotes.js to start and pause automatic quote rotation based on the toggle state.
Event Handling: Attached a 'change' listener to the toggle input to dynamically handle state changes.