London | 26-ITP-May | Dipa Sarker| Sprint 3 | Quote Generator App - #1286
Open
Dipa-Sarker wants to merge 4 commits into
Open
London | 26-ITP-May | Dipa Sarker| Sprint 3 | Quote Generator App#1286Dipa-Sarker wants to merge 4 commits into
Dipa-Sarker wants to merge 4 commits into
Conversation
Dipa-Sarker
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good, the app works. I have a small improvement suggestion
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
|
|
||
| const quoteElement = document.querySelector("#quote"); |
There was a problem hiding this comment.
If you are using IDs, is there a better method to use than querySelector?
Author
There was a problem hiding this comment.
Is it querySelectorAll( ) ?
There was a problem hiding this comment.
querySelectorAll is when you want more than one item matching a particular selector. I am thinking about a function that can efficiently find one element, if you know its ID
There was a problem hiding this comment.
yes, getElementById is more efficient if you know you are looking for a specific ID. Can you try making that change?
Author
There was a problem hiding this comment.
I made correction using getElementById(id).
LonMcGregor
added
Reviewed
Dipa-Sarker
added
Needs Review
LonMcGregor
added
Reviewed
Dipa-Sarker
added
Needs Review
LonMcGregor
added
Reviewed
Dipa-Sarker
added
Needs Review
|
Great, task complete |
LonMcGregor
added
Complete
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist