London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Groups - #1268
Open
shehu-dona wants to merge 12 commits into
Open
London | May-26 | Liridona Shehu | Sprint 1 | Module-Data-Groups #1268shehu-dona wants to merge 12 commits into
shehu-dona wants to merge 12 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
shehu-dona
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
shehu-dona
changed the title
This comment has been minimized.
This comment has been minimized.
shehu-dona
changed the title
shehu-dona
changed the title
shehu-dona
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, some comments for improvements, but all tests pass
| @@ -1 +1,5 @@ | |||
| function dedupe() {} | |||
| function dedupe(elements) { | |||
| return Array.from(new Set(elements)); | |||
| let filteredNumericValues = elements.filter((item) => Number.isFinite(item)); | ||
| console.log(filteredNumericValues); | ||
|
|
||
| return Math.max(...filteredNumericValues); |
There was a problem hiding this comment.
Can you implement this without using built-in max?
LonMcGregor
added
Reviewed
shehu-dona
added
the
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
A PR with implementing and rewrite tests.