Glasgow | 26-ITP-May | Chan Yat Long | Sprint 3 | Alarm Clock - #1256
Open
Motorcycle-lab wants to merge 5 commits into
Open
Glasgow | 26-ITP-May | Chan Yat Long | Sprint 3 | Alarm Clock#1256Motorcycle-lab wants to merge 5 commits into
Motorcycle-lab wants to merge 5 commits into
Conversation
Motorcycle-lab
added
📅 Sprint 3
Motorcycle-lab
changed the title
Motorcycle-lab
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
I think there is still a lot left to finish on this task, see my comments for hints. Remember to fully test before making a PR
There was a problem hiding this comment.
Is there anything missing in this file?
| </html> | ||
|
|
||
|
|
||
|
|
| //into the second. | ||
|
|
||
| let alarmInterval; | ||
| const InputField = document.querySelector("#alarmSet"); |
There was a problem hiding this comment.
If you are using an ID, is there a better method to use than querySelector?
LonMcGregor
added
Reviewed
added 2 commits
July 31, 2026 12:13
Motorcycle-lab
added
Needs Review
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, the alarm clock functions better now
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
done
Questions
Great