-
-
Notifications
You must be signed in to change notification settings - Fork 327
Glasgow | 26-ITP-May | Sandani Kannangara | sprint 2 | Data groups #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SandzSoft
wants to merge
19
commits into
CodeYourFuture:main
Choose a base branch
from
SandzSoft:data-groups/sprint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a48c9ea
Fix object property access in address.js
SandzSoft c82a59f
Fix for...of loop in author.js using Object.values()
SandzSoft dd14256
Fix object printing in template literal in recipe.js
SandzSoft 1b5d78e
add Jest tests for contains including empty objects and invalid input
SandzSoft 7879178
implement contains function and add invalid input test cases
SandzSoft c11d992
add Jest tests for createLookup function
SandzSoft 2cb0162
implement createLookup function
SandzSoft dcc8662
implement parseQueryString with edge case handling
SandzSoft 43d9b1f
add Jest tests for tally function edge cases
SandzSoft a1915e0
implement tally function and add integer array test cases
SandzSoft 3441e66
Implement invert function and add explanation
SandzSoft a34e883
add full Jest tests and invalid input handling for invert
SandzSoft 0fa3671
split calculateMode into smaller functions
SandzSoft fdb0736
implement countWords function with edge case handling
SandzSoft 6dc4d28
implement totalTill coin value calculation
SandzSoft c8e54f1
Add for loop to recipe function based on review feedback
SandzSoft 92d720c
Trigger CI check again
SandzSoft d6d7b68
d edge case tests and update parseQueryString
SandzSoft a3f8710
Update recipe with separate print function
SandzSoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| function contains() {} | ||
| function contains(obj, val) { | ||
| if (typeof obj !== "object" || obj === null || Array.isArray(obj)) { | ||
| return false; | ||
| } | ||
| return Object.keys(obj).includes(val); | ||
| } | ||
|
|
||
| module.exports = contains; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| let newObj = {}; | ||
| if (!Array.isArray(countryCurrencyPairs)) { | ||
| throw new Error("Input must be an array"); | ||
| } | ||
|
|
||
| countryCurrencyPairs.forEach((pair) => { | ||
| if (Array.isArray(pair) && pair.length === 2) { | ||
| newObj[pair[0]] = pair[1]; | ||
| } | ||
| }); | ||
| return newObj; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| function tally() {} | ||
|
|
||
| function tally(input) { | ||
| const obj = {}; | ||
| if (input === null || !Array.isArray(input)) { | ||
| throw new Error("Invalid input"); | ||
| } | ||
| input.forEach((el) => { | ||
| obj[el] = (obj[el] || 0) + 1; | ||
| }); | ||
| return obj; | ||
| } | ||
| module.exports = tally; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.