London | 26-May-ITP | Yonatan Teklemariam | Sprint 1 | exercises - #1235
Open
Yonatanteklemariam wants to merge 8 commits into
Open
London | 26-May-ITP | Yonatan Teklemariam | Sprint 1 | exercises#1235Yonatanteklemariam wants to merge 8 commits into
Yonatanteklemariam wants to merge 8 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
changed the title
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
changed the title
…firm everything goes smoothly
Yonatanteklemariam
changed the title
Yonatanteklemariam
added
the
Needs Review
Author
|
@LonMcGregor, Good afternoon Lon, i hope you're doing well. Could you please review my PR? I submitted it 4 days ago. Thanks |
LonMcGregor
reviewed
Jul 13, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, lots of good test cases. I have one comment about an if branch in your max file.
| let max = -Infinity; | ||
| for (const value of elements) { | ||
| if (typeof value === "number" && !Number.isNaN(value)) { | ||
| if (value > max) { |
There was a problem hiding this comment.
Try to be careful about having lots of nested if conditions. Is there a way these could be combined?
Author
There was a problem hiding this comment.
yes there's. I believe I can collapse into one condition, like on the code snippet added.
LonMcGregor
added
Reviewed
collapsed into one condition
Yonatanteklemariam
added
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
fixed all the to-be implemented functions and fixed as well as re-run the tests to make sure everything goes smoothly