Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Alarm Clock - #1178
Closed
Seti-Jemal wants to merge 6 commits into
Closed
Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Alarm Clock#1178Seti-Jemal wants to merge 6 commits into
Seti-Jemal wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
cjyuan
reviewed
Apr 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
Given a countdown is still active, when the users click the "Set Alarm" button with input equals to 0, then what do you expect the app to behave?
-
While a countdown is active, does the timer display look normal to you?
Note: We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask AI Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file? (You have made some major changes to the original code, so don't worry about that this time).
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
Contributor
|
No new commits on this branch on GitHub yet. |
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Apr 17, 2026
Comment on lines
+58
to
+59
| timeRemaining = 0; | ||
| updateDisplay(timeRemaining); |
Contributor
There was a problem hiding this comment.
When the condition at line 54 becomes true, what value is timeRemaining?
Is there any need to perform the tasks on line 58-59?
Author
There was a problem hiding this comment.
No, those lines are not needed because timeRemaining is already on 0.
Contributor
There was a problem hiding this comment.
If they are not needed, why not remove them?
cjyuan
added
Reviewed
Seti-Jemal
removed
the
Reviewed
Seti-Jemal
added
the
Needs Review
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have completed sprint 3 alarm clock.