London | 26-ITP-JAN | Asha Ahmed | Sprint 3 | Quote Generator - #1142
Closed
ashaahmed7 wants to merge 6 commits into
Closed
London | 26-ITP-JAN | Asha Ahmed | Sprint 3 | Quote Generator#1142ashaahmed7 wants to merge 6 commits into
ashaahmed7 wants to merge 6 commits into
Conversation
ashaahmed7
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 6, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done.
Nice and clear commit messages. This makes it easier to understand what each commit does
| if (autoplayToggle.checked) { | ||
| // Switch is ON | ||
| autoplayStatus.innerText = "auto-play: ON"; | ||
| timerId = setInterval(updateQuote, 5000); |
There was a problem hiding this comment.
Nice implementation of the stretch task (however the text should change every 60s)
Luro91
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
• Changed html file based on success criteria
• Updated CSS file to style the page
• Added a checkbox – When switched on, a quote should be generated every 5 seconds.
Questions
N/A