Manchester | 26-ITP-Jan | Abdu Hassen | Sprint 2| Data-Grouping - #1121
Closed
Abduhasen wants to merge 3 commits into
Closed
Manchester | 26-ITP-Jan | Abdu Hassen | Sprint 2| Data-Grouping#1121Abduhasen wants to merge 3 commits into
Abduhasen wants to merge 3 commits into
Conversation
Abduhasen
added
📅 Sprint 2
cjyuan
reviewed
Apr 1, 2026
cjyuan
added
Reviewed
Abduhasen
added
Needs Review
cjyuan
reviewed
Apr 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
- Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
- You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
- Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
- Without this label, the reviewer would not know if your changes is ready to be reviewed.
| // Then it should return false or throw an error | ||
| test("the function should return false when invalid parameter like an array is passed", () => { | ||
| expect(contains([10, 23, 34, 45], "3")).toBe(false); | ||
| expect(contains("hello", "hi")).toBe(false); |
Contributor
There was a problem hiding this comment.
Note: String also have their indices acting as keys.
Object.hasOwn("hello", "0") evaluates to true.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-debugging of codes
-implementing of codes
-interpreting of codes
Questions
N/A