Skip to content

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Book Library - #535

Open
khaliun-dev wants to merge 3 commits into
CodeYourFuture:mainfrom
khaliun-dev:sprint-2/book-library
Open

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Book Library#535
khaliun-dev wants to merge 3 commits into
CodeYourFuture:mainfrom
khaliun-dev:sprint-2/book-library

Conversation

@khaliun-dev

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed books not rendering on page load
  • Fixed error when submitting a new book
  • Fixed author being saved as the title
  • Fixed broken delete buttons
  • Fixed incorrect read status
  • Added validation for missing author
  • Clear the form after successfully adding a book

Testing

  • Tested adding books
  • Tested missing fields
  • Tested read/unread status
  • Tested deleting books
  • Checked browser console for error

Questions

None.

@khaliun-dev khaliun-dev added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 11, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants