London | 26-ITP-May | Yonatan Teklemariam | Sprint 2 | Book Library

[Yonatanteklemariam]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

fixed the wrong variable name of the library
corrected the author field and changed it to author.value
repaired the read/unread logic
fixed the delete button by fixing the correct variable name
repaired the syntax error in the render function

Questions

[cjyuan]

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[cjyuan]

Changes is solid. Just a few more suggestions.

[cjyuan]

Some of the checks are probably redundant.

[cjyuan]

I meant to point out: !Number.isInteger(pagesNumber) also covers isNaN(pagesNumber)

Even though the HTML form has been prepared to ensure the input is a whole number, it is still a safer practice to check the input again in JS.

[cjyuan]

Changes look good.

[Yonatanteklemariam]

Thank you for your persistence and mentoring me through the right direction. I've removed the validation in the js as a form with its inbuilt validation is added in the html. But it's essential to have some validation in the js as you suggested as well.