Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | Book-Library - #531
Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | Book-Library #531Abduhasen wants to merge 4 commits into
Conversation
Abduhasen
added
📅 Sprint 2
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…Possible Improvement`
Abduhasen
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const readCheckbox = document.getElementById("check"); | ||
| const bookForm = document.getElementById("bookForm"); | ||
| const bookList = document.getElementById("bookList"); |
There was a problem hiding this comment.
Common practice is to declare all shared variables/constants at the beginning of the file (before function definition).
| myLibrary.splice(i, 1); | ||
| render(); | ||
|
|
||
| alert(`You've deleted title: ${deletedTitle}`); |
There was a problem hiding this comment.
alert() is a blocking function call. As a result, invoking it prevents the browser from updating the UI until the dialog is dismissed.
If time permits, research for approaches that allows the UI to update before displaying the alert dialog. (This is an optional change).
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
debugging using devtools, fixing codes
Questions