Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Book Library - #528

Open
tomdu3 wants to merge 11 commits into
CodeYourFuture:mainfrom
tomdu3:sprint-2/book-library
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Book Library#528
tomdu3 wants to merge 11 commits into
CodeYourFuture:mainfrom
tomdu3:sprint-2/book-library

Conversation

@tomdu3

@tomdu3 tomdu3 commented Aug 8, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added bug fixes for the Book Library App.

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 8, 2026
@tomdu3 tomdu3 changed the title London | 26-ITP-May | Tomislav | Sprint 2 | Book Library London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Book Library Aug 8, 2026
@tomdu3 tomdu3 mentioned this pull request Aug 8, 2026
Open
2 tasks
cjyuan
cjyuan reviewed Aug 8, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 8, 2026
cjyuan
cjyuan reviewed Aug 8, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look pretty solid. There are a few improvements you could still make.

Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 8, 2026
cjyuan
cjyuan reviewed Aug 9, 2026
View reviewed changes

@cjyuan cjyuan left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. However, new code introduces some inconsistency and redundancy.

Comment thread debugging/book-library/script.js
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2026
@tomdu3 tomdu3 removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 9, 2026
@tomdu3 tomdu3 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 9, 2026
@cjyuan

cjyuan commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

All good now.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2026
@tomdu3

tomdu3 commented Aug 10, 2026

Copy link
Copy Markdown
Author

@cjyuan Thank you for the time spent on this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @cjyuan