London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Book library by cywong-dev · Pull Request #525 · CodeYourFuture/Module-Data-Flows

cywong-dev · 2026-08-07T17:24:32Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR provides the answer for the coursework book library

for the function submit

for typo mistake

Fix variable name for delete button in script.js

There is no event called clicks

for wrong insertion order

Read/unread saves the wrong answer

Fix the sequence

Remove newline characters; Change "127" to 127 ; Simplify two push statement to one push statement

Refactor submit function to improve input validation.

Refactor row deletion logic to use while loop for clarity.

Refactor loop to directly use myLibrary.length and simplify read status button logic.

Removed the call to render() when initializing the library.

cjyuan

The checkboxes in the PR description are not yet properly marked up in Markdown syntax.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

Fix multiple issues in book library functionality, including correcting variable names, logic for read status, and ensuring proper rendering of books.

cywong-dev · 2026-08-09T17:29:34Z

Yes, changed. Please kindly check?

cjyuan

According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?

Updated title and meta tags in the head section. Changed input types for title and author fields to 'text'.

cywong-dev · 2026-08-10T18:00:16Z

According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?

Fixed. Please kindly check?

Remove my name in the comment as I am the only one developer in the project

Clear the table's inner HTML to remove old rows.

Remove unused variable 'rowsNumber' in render function.

Updated the submit function to use the correct trimmed value

Added a helper function to display status messages in the UI and updated the submit function to use it. Also fixed variable name from 'mylibrary' to 'myLibrary'.

Added table header for book library display.

cjyuan · 2026-08-10T21:24:07Z

-  let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
+  table.innerHTML = "";


You could also clear only <tbody>. This way, you don't need to recreate the header row.

cjyuan · 2026-08-10T21:35:41Z

        <input
          type="submit"
          value="Submit"
          class="btn btn-primary"
          onclick="submit();"
        />


Could you use AI to find out the tradeoff between attaching event listener in HTML and in JavaScript?

cjyuan · 2026-08-11T08:28:47Z

+          min="1"
+          step="1"
+          oninput="this.value = this.value.replace(/[^0-9]/g, '').replace(/^0+/, '');"
          required


The JS code works to certain extent but it introduces some unusual behavior to the input field. For example, when I pressed '1', '2', '3', 'e', the input field was cleared.

Adding min="1", step="1" and required would be enough if the input element is inside a <form>. When the input elements are in a <form> , the constraints would have been checked by the browser when the user submits the form (clicks the "Submit" button).

cjyuan · 2026-08-11T08:40:49Z

+    return;
  }
+
+  let book = new Book(titleValue, authorValue, pagesValue, check.checked);


This would lead to

New books store page count as strings.

The books created in populateStorage() store page count as numbers.

Could you find a way to represent same kind of value using the same data type?

Also, even if the HTML code is already prepared to accept only input containing digits, it is still a safe practice to check the input again in JS.

cywong-dev added 14 commits August 7, 2026 17:25

Fix syntax error in for loop for row deletion

286b82e

Change library to mylibrary for book storage

fbcee08

for the function submit

Fix book constructor to use author value

1da4c07

for typo mistake

Correct delete button variable name

6350c1a

Fix variable name for delete button in script.js

Fix event listener typo for delete button

d030a55

There is no event called clicks

Change row insertion to append at the end of table

780b6ac

for wrong insertion order

Fix read status check in script.js

ef6d410

Read/unread saves the wrong answer

Table deletion broken

b74b562

Fix the sequence

Refactor book creation and storage in populateStorage

f1bcc2a

Remove newline characters; Change "127" to 127 ; Simplify two push statement to one push statement

Enhance input validation in submit function

f447b3d

Refactor submit function to improve input validation.

Fix empty table shown initially

35a2793

Refactor row deletion logic to use while loop for clarity.

Simplify rendering of library rows and buttons

d620ffb

Refactor loop to directly use myLibrary.length and simplify read status button logic.

Fix delete button creation and event listener

a8f4d2c

Remove render call during library initialization

374ddfd

Removed the call to render() when initializing the library.

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 7, 2026

cjyuan reviewed Aug 7, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2026

Add comments to explain detail changes

456c37a

Fix multiple issues in book library functionality, including correcting variable names, logic for read status, and ensuring proper rendering of books.

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 9, 2026

cjyuan reviewed Aug 10, 2026

View reviewed changes

Comment thread debugging/book-library/script.js

Comment thread debugging/book-library/script.js Outdated

Comment thread debugging/book-library/script.js Outdated

Comment thread debugging/book-library/script.js Outdated

Comment thread debugging/book-library/script.js Outdated

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 10, 2026

Update HTML structure and input types for html validation

023159b

Updated title and meta tags in the head section. Changed input types for title and author fields to 'text'.

cywong-dev added 2 commits August 10, 2026 19:03

Fix book1 page number type in populateStorage

1e71bf3

Remove developer name comment

1cf530c

Remove my name in the comment as I am the only one developer in the project

cywong-dev added 5 commits August 10, 2026 19:12

Fix rendering issue by clearing table content

bb941e0

Clear the table's inner HTML to remove old rows.

Remove unused variable in render function

7f0c9c1

Remove unused variable 'rowsNumber' in render function.

Use trimmed values instead of untrimmed values for updating

65c0c35

Updated the submit function to use the correct trimmed value

Implement status message display and fix variable name

c0684e9

Added a helper function to display status messages in the UI and updated the submit function to use it. Also fixed variable name from 'mylibrary' to 'myLibrary'.

Add table header to book library

c5d9795

Added table header for book library display.

cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 10, 2026

cjyuan reviewed Aug 10, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 10, 2026

cywong-dev added 3 commits August 11, 2026 09:12

Add input validation for pages number field

335ed1f

Refactor variable names for clarity in script.js

372ee5b

Change myLibrary to a constant

57bbea8

cjyuan reviewed Aug 11, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Book library - #525

London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Book library#525
cywong-dev wants to merge 26 commits into
CodeYourFuture:mainfrom
cywong-dev:book-library

cywong-dev commented Aug 7, 2026 •

edited

Loading

Uh oh!

cjyuan left a comment

Uh oh!

cywong-dev commented Aug 9, 2026

Uh oh!

cjyuan left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cywong-dev commented Aug 10, 2026

Uh oh!

Uh oh!

cjyuan Aug 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Aug 10, 2026

Uh oh!

cjyuan Aug 11, 2026

Uh oh!

cjyuan Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

cywong-dev commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cywong-dev commented Aug 9, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cywong-dev commented Aug 10, 2026

Uh oh!

Uh oh!

cjyuan Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cywong-dev commented Aug 7, 2026 •

edited

Loading

cjyuan Aug 10, 2026 •

edited

Loading