Skip to content

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Fix library debugging - #524

Open
SandzSoft wants to merge 10 commits into
CodeYourFuture:mainfrom
SandzSoft:fix-library-debugging
Open

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Fix library debugging#524
SandzSoft wants to merge 10 commits into
CodeYourFuture:mainfrom
SandzSoft:fix-library-debugging

Conversation

@SandzSoft

@SandzSoft SandzSoft commented Aug 7, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed books not rendering on page load.
  • Fixed errors when adding new books.
  • Fixed author field using title value.
  • Fixed delete button functionality.
  • Fixed read status handling.
  • Added validation for required fields.
  • Added form reset after adding books.
  • Refactored DOM handling to use tbody.
  • Improved variable naming and readability.

@SandzSoft SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 7, 2026
cjyuan
cjyuan reviewed Aug 7, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2026
@SandzSoft SandzSoft added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 8, 2026
cjyuan
cjyuan reviewed Aug 8, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in your index.html. Could you fix these errors?

cjyuan
cjyuan reviewed Aug 8, 2026
View reviewed changes
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@SandzSoft SandzSoft added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 9, 2026
@SandzSoft

SandzSoft commented Aug 9, 2026

Copy link
Copy Markdown
Author

According to https://validator.w3.org/, there are errors in your index.html. Could you fix these errors?

Fixed the HTML validation errors and verified index.html with the W3C validator. It now passes validation.

@SandzSoft

SandzSoft commented Aug 9, 2026

Copy link
Copy Markdown
Author

Thanks for the helpful feedback! I've fixed the issues and learned a lot from the suggestions.

@SandzSoft SandzSoft added the Module-Data-Flows The name of the module. label Aug 9, 2026
cjyuan
cjyuan reviewed Aug 9, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but (because you deleted something needed by Bootstrap) the form no longer works properly. Could you fix this issue?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 9, 2026
@SandzSoft

SandzSoft commented Aug 9, 2026

Copy link
Copy Markdown
Author

Changes look good, but (because you deleted something needed by Bootstrap) the form no longer works properly. Could you fix this issue?

Thanks for pointing this out! I fixed the HTML validation issues and restored the required Bootstrap JavaScript dependencies.

@SandzSoft SandzSoft removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 9, 2026
@SandzSoft SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 9, 2026
@cjyuan

cjyuan commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

All good now.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SandzSoft @cjyuan