Skip to content

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Amaechina wants to merge 22 commits into
base: main
Choose a base branch
from
+91 −103
Open

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
686f27d
added the closing parenthesis in the for loop
Tobias-Amaechina Aug 5, 2026
11d4e80
used the correct variable name myLibrary inside the submit function
Tobias-Amaechina Aug 5, 2026
9acc884
added the autho.value by deleting one of the title.value that was pa…
Tobias-Amaechina Aug 5, 2026
127e4f4
changed every instance of delBut with delButton
Tobias-Amaechina Aug 5, 2026
8314db5
correct the event name by it correct name click
Tobias-Amaechina Aug 5, 2026
8c9db43
changed the wrong logically check from false to yes
Tobias-Amaechina Aug 5, 2026
f839c7b
added additional validation for book's author
Tobias-Amaechina Aug 5, 2026
ab117d6
remove the table element from the index.html
Tobias-Amaechina Aug 5, 2026
55bfed4
add the button ID
Tobias-Amaechina Aug 5, 2026
ab20798
appen the corrent variable name delButton
Tobias-Amaechina Aug 5, 2026
2606f98
let the row start to add from top
Tobias-Amaechina Aug 5, 2026
41cc5fb
Removed all the syntax error in the index.html file
Tobias-Amaechina Aug 10, 2026
25eb25e
change the variable declation of myLibrary with const as it will nev…
Tobias-Amaechina Aug 10, 2026
093b70c
give meaningful varaible name in the DOM nodes
Tobias-Amaechina Aug 10, 2026
ecd8a2f
removes the seond render call when window laods
Tobias-Amaechina Aug 10, 2026
e18af51
create a book model class
Tobias-Amaechina Aug 10, 2026
402f3c0
add the default book load onec
Tobias-Amaechina Aug 10, 2026
57d4d12
handle form submission
Tobias-Amaechina Aug 10, 2026
9902cfc
implement render Table , toggleread button and delete button
Tobias-Amaechina Aug 10, 2026
71dadca
Added the non Blocking mesage and fixed the bug in handleSubmit name…
Tobias-Amaechina Aug 10, 2026
bbef966
Attached handleSubmit function to window and deleted vscode and sett…
Tobias-Amaechina Aug 10, 2026
cde0d51
Restore .vscode file to avoid validator failure
Tobias-Amaechina Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>Book Library </title>
<meta
charset="utf-8"
name="viewport"
charset="utf-8">
<meta name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
Expand All @@ -26,20 +26,21 @@ <h1>Library</h1>
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div id="messageBox"></div>

<div id="demo" class="collapse">
<div class="form-group">
<form id="bookForm" class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -62,13 +63,13 @@ <h1>Library</h1>
/>Read
</label>
<input
type="submit"
type="button"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="handleSubmit();"

@cjyuan cjyuan Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Look up the trade-off among different approaches for attaching event listener to HTML elements. In particulars,

  • Via HTML attribute in HTML
  • In JS, using .addEventListener()

/>
</form>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
Expand All @@ -80,17 +81,10 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>

</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
</html>
158 changes: 76 additions & 82 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,97 @@
let myLibrary = [];
// Data store this variable never changes
const myLibrary = [];

// DOM nodes
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheck = document.getElementById("check");
const tableBody = document.querySelector("#display tbody");



// Book model
class Book {
constructor(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages;
this.read = read;
}
}
// initial load
window.addEventListener("load", function (e) {
populateStorage();
render();
});

// Add default books only once
function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
if (myLibrary.length === 0) {
myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true));
myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true));
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
// Handle form submission
window.handleSubmit = function handleSubmit() {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
if (!title || !author || !pages || pages <= 0) {

@cjyuan cjyuan Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of number should pages be? Could it be NaN?

showMessage("Please enter valid book details.");
return;
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}
const book = new Book(title, author, pages, readCheck.checked);
myLibrary.push(book);

render();
showMessage(`Added "${title}" to your library.`);
}

// Render table
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
tableBody.innerHTML = "";

myLibrary.forEach((book, index) => {
const row = tableBody.insertRow();

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
row.insertCell().textContent = book.title;
row.insertCell().textContent = book.author;
row.insertCell().textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// Toggle read button
const readCell = row.insertCell();
const toggleReadBtn = document.createElement("button");
toggleReadBtn.className = "btn btn-success btn-sm";
toggleReadBtn.textContent = book.read ? "Yes" : "No";
toggleReadBtn.addEventListener("click", () => {
book.read = !book.read;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
readCell.appendChild(toggleReadBtn);
// Delete button
const deleteCell = row.insertCell();
const deleteBtn = document.createElement("button");
deleteBtn.className = "btn btn-warning btn-sm";
deleteBtn.textContent = "Delete";
deleteBtn.addEventListener("click", () => {
myLibrary.splice(index, 1);
render();
showMessage(`Deleted "${book.title}".`);
});
}
deleteCell.appendChild(deleteBtn);
});
}

// Non-blocking message
function showMessage(msg) {
const box = document.getElementById("messageBox");
box.innerHTML = `
<div class="alert alert-info alert-dismissible fade show" role="alert">
${msg}
<button type="button" class="close" data-dismiss="alert">&times;</button>
</div>
`;
}
Loading