West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 2 | Book-Library

[alizada-dev]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Bugs that I fixed:

• Website loads and shows the books in my library
• Error in console fixed
• It uses the appropriate title name and the author name
• The delete button works now
• When a book that I say I've read is added, it saves the right answer
• The form inputs clear after a book is added

Please let me know of any more bugs (if yet to be fixed)

[cjyuan]

• You checked the trimmed value but you are using the untrimmed values. A better approach is to first store the preprocessed input in variables, then use those cleaned values consistently throughout the rest of the code.

• pagesInput.value is a string, and a number in scientific format may look unnatural as "number of pages".

[alizada-dev]

Got it, sir. Thank you for this out. Could you check if it is okay this time?

function submit() {
  const trimmedTitle = titleInput.value.trim();
  const trimmedAuthor = authorInput.value.trim();
  const trimmedPages = +pagesInput.value.trim();

  if (
    !trimmedTitle ||
    !trimmedAuthor ||
    !trimmedPages
  ) {
    alert("Please fill all fields!");
    return false;
  } else {
    let book = new Book(trimmedTitle, trimmedAuthor, trimmedPages, readCheckbox.checked);
    myLibrary.push(book);

    titleInput.value = "";
    authorInput.value = "";
    pagesInput.value = "";
    readCheckbox.checked = false;
    render();
  }
}

[cjyuan]

These are the properties of a book. They are not DOM elements. The original names (except maybe check) are more natural.

[alizada-dev]

You are absolutely right.

function Book(title, author, pages, check) {
  this.title = title;
  this.author = author;
  this.pages = pages;
  this.check = check;
}

  titleCell.textContent = myLibrary[i].title;
   authorCell.textContent = myLibrary[i].author;
   pagesCell.textContent = myLibrary[i].pages;

[cjyuan]

Changes look good.

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.